Fix for templates #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I closed the previous PR (#14) because I realized that it was still showing templates in the project list, which didn't make sense. So, moving the |
|
Thanks, I'll have a look at it and merge asap 👍 |
mdeboer
approved these changes
Dec 12, 2017
|
Thank you for your PR! 👍 I took the liberty of editing your code and move the logic to the |
mdeboer
added a commit
that referenced
this pull request
Dec 12, 2017
Skip projects (templates) in projects list that don’t have paths defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project.jsthrows errors if you are using templates in yourprojects.csonconfig because templates don't have any definedpaths. So, ifproject.pathsis falsy, then just skip it, since there's nothing to open anyway.