Allow the Atom app name to be configurable #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I didn't take in account beta versions as I assumed they would be called Atom as well. It makes sense to add an env var to change this. I'll have a look at it and merge a.s.a.p 👍 |
|
Hi, I finally upgraded to Alfred 3 and installed this workflow, and I also use |
mdeboer
approved these changes
Dec 12, 2017
|
I will merge this PR together with some other changes and is scheduled for v2.3.2 later today. Thank you for the PR! 👍 |
mdeboer
added a commit
that referenced
this pull request
Dec 12, 2017
Make Atom app name configurable to make it work with Atom Beta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're running a non-stable version of Atom (i.e. Atom Beta), then the
opencommand errors out because it can't find an app calledAtom. So, let's default to "Atom" but let the user override it in an env var calledatomAppName.