Modify PatchACPI to assign processorIDs from DSDT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS assumes that the first processor from DSDT is always enabled, without checking MADT table here we're trying to assign first IDs found in DSDT to enabled processors in MADT, such that macOS assumption to be true
and resolves an uninitialized read: ...... LocalApicNMI++; ApicTable->Length += LocalApicNMI->Length; ......
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS assumes that the first processor from DSDT is always enabled, without checking MADT table.
Here we're trying to assign first IDs found in DSDT to enabled processors in MADT, such that macOS assumption to be true.
This change should fix some X79 boards with strange DSDT: https://pastebin.com/raw/SZRn1BGj (cpu: 80, 81, 00, 01, .... 0f, 82....).
Now whatever is present in DSDT should be mirrored to MADT.