Optimizations #45
Optimizations #45
Conversation
Maiori44
added
enhancement
|
is this ready to be merged? |
|
Not yet, still working on it |
|
maybe you should make it into a draft until it's ready |
…nnecessary I/O operations
…the memory allocation each time something is added to the string
Made the benchmark results even more accurate
Created a macro for calling `push_str` Using the macro (runtime went down from ~770000 ns to ~290000 ns)
|
I fear the day I'll have to merge 2.5.1 and 2.5.2 to next, since it'll definitely break this too |
|
I can only imagine your pain LEL |
|
I can’t even imagine how painful this would be |
|
The day of reckoning arrived, merge conflicts are here, how do we fix this pr lmao |
I will try to handle it later |
|
shouldn't @Enn3Developer have to handle it? since it's their fork regardless, to whoever does handle the merge conflict, make sure to not accidentally remove any 2.5.X feature |
If @Enn3Developer is available to do so yes |
|
Oh, mhh... I didn't think it was me that should fix all the conflicts. Fuck. |
Well you don’t have to fix everything at once we can kinda split the work. But you mostly did the optimizations so you know the code better. |
|
Well, I'm still working on it so we'll see |
|
You 2 could handle the smaller things and leave what may be 2.5.X content to me |
…ed on every platform thus it is optional)
So, there are rooms for optimizations here and there, these may be small but nevertheless are optimizations.
The scope of this pr is to create a benchmarking tool, too, to have more accurate results when checking if an optimization either does work or not.