fix: Cap length of column name #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasNicolaisen
force-pushed
the
fix/cap-length-of-column-name
branch
from
4ffb4e0
to
bcadc16
Compare
AndreasNicolaisen
force-pushed
the
fix/cap-length-of-column-name
branch
from
fc171a9
to
0f4f5fa
Compare
AndreasNicolaisen
force-pushed
the
fix/cap-length-of-column-name
branch
from
0f4f5fa
to
2c5ec05
Compare
zvirja
reviewed
Dec 14, 2023
| sanitizedSqlName = $"_{sanitizedSqlName}"; | ||
| } | ||
|
|
||
| if (sanitizedSqlName.Length > 127) // 127 instead of 128, since we need space for parameter declaration '@' |
There was a problem hiding this comment.
I thought about doing that for values over 118. If they are larger than that, we should calculate hash for them.
In this case the chance of just having a vocalubary key with a collision hash is lower or statistically negligible.
With the current approach it's possible for people to mimic hash value by just having columns of length of 127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work Item ID: AB#30770
Cap length of column names.
Test approach
Run stream/new unit test
Release Note
fix: Cap length of column names. If names are longer than 127 characters, we cut off anything after character 116, and append hash value of the entire name.