Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

97 107 mark and show shared #116

Merged
merged 8 commits into from
Jun 1, 2023
Merged

97 107 mark and show shared #116

merged 8 commits into from
Jun 1, 2023

Conversation

spacehamster87
Copy link
Contributor

Main Additions:

  • Display [Shared] marker in metric plot top-right corner if shared data (e.g. mem_used) for shared node jobs
  • Query and display concurrently running shared jobs on same node as viewed shared job in job view
    • Concurrent jobs are queried by their overlap in startTime and duration in respect to viewed job
    • Logic 1: "Query jobs which startTime is between viewed jobs' startTime + 10 Seconds and startTime + duration - 10 Seconds"
    • Logic 2: "Query jobs which startTime + duration is between viewed jobs' startTime + 10 Seconds and startTime + duration - 10 Seconds"

@spacehamster87
Mark shared metrics on shared jobs
e9301a5 
- show [shared] in plots in JobList
- other plot locations Todo
- Relates to issue #107
@spacehamster87
List parallel jobs on node for jobs on shared node
d93610f 
- Relates to issue #97
- required GQL schema extension and regeneration
- Works for archived jobs aswell
@spacehamster87
Add shared metric marker to job view plots
a337482
@spacehamster87
Move concurrentJobs as field to main job query
270750a
@spacehamster87
Fix test: Change jobId conversion to fmt
5bb5e5e
This was linked to issues May 16, 2023
Clearly mark shared metrics for jobs sharing nodes #107
Closed
Show jobs running on same node in job view #97
Closed
@spacehamster87 spacehamster87 marked this pull request as ready for review June 1, 2023 13:25
@spacehamster87
Merge branch 'master' into 97_107_mark_and_show_shared
a6cb833 
- Solves query.go conflict by splitting QueryJobLinks function aswell
@spacehamster87 spacehamster87 merged commit 0d4935e into master Jun 1, 2023
2 checks passed
@spacehamster87 spacehamster87 deleted the 97_107_mark_and_show_shared branch June 1, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moebiusband73 moebiusband73 Awaiting requested review from moebiusband73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearly mark shared metrics for jobs sharing nodes Show jobs running on same node in job view
1 participant
@spacehamster87