Skip to content

Commit

Permalink
Put token authentication in separate file
Browse files Browse the repository at this point in the history
  • Loading branch information
moebiusband73 committed May 6, 2024
1 parent 8c9761f commit 5ca66ae
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 48 deletions.
48 changes: 0 additions & 48 deletions internal/api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,18 @@ import (
"crypto/ed25519"
"encoding/base64"
"encoding/json"
"errors"
"fmt"
"io"
"log"
"math"
"net/http"
"strconv"
"strings"
"sync"
"time"

"github.com/ClusterCockpit/cc-metric-store/internal/config"
"github.com/ClusterCockpit/cc-metric-store/internal/memorystore"
"github.com/ClusterCockpit/cc-metric-store/internal/util"
"github.com/golang-jwt/jwt/v4"
"github.com/gorilla/mux"
"github.com/influxdata/line-protocol/v2/lineprotocol"
)
Expand Down Expand Up @@ -322,51 +319,6 @@ func handleDebug(rw http.ResponseWriter, r *http.Request) {
}
}

func authentication(next http.Handler, publicKey ed25519.PublicKey) http.Handler {
cacheLock := sync.RWMutex{}
cache := map[string]*jwt.Token{}

return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
authheader := r.Header.Get("Authorization")
if authheader == "" || !strings.HasPrefix(authheader, "Bearer ") {
http.Error(rw, "Use JWT Authentication", http.StatusUnauthorized)
return
}

rawtoken := authheader[len("Bearer "):]
cacheLock.RLock()
token, ok := cache[rawtoken]
cacheLock.RUnlock()
if ok && token.Claims.Valid() == nil {
next.ServeHTTP(rw, r)
return
}

// The actual token is ignored for now.
// In case expiration and so on are specified, the Parse function
// already returns an error for expired tokens.
var err error
token, err = jwt.Parse(rawtoken, func(t *jwt.Token) (interface{}, error) {
if t.Method != jwt.SigningMethodEdDSA {
return nil, errors.New("only Ed25519/EdDSA supported")
}

return publicKey, nil
})
if err != nil {
http.Error(rw, err.Error(), http.StatusUnauthorized)
return
}

cacheLock.Lock()
cache[rawtoken] = token
cacheLock.Unlock()

// Let request through...
next.ServeHTTP(rw, r)
})
}

func StartApiServer(ctx context.Context, httpConfig *config.HttpConfig) error {
r := mux.NewRouter()

Expand Down
56 changes: 56 additions & 0 deletions internal/api/authentication.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package api

import (
"crypto/ed25519"
"errors"
"net/http"
"strings"
"sync"

"github.com/golang-jwt/jwt/v4"
)

func authentication(next http.Handler, publicKey ed25519.PublicKey) http.Handler {
cacheLock := sync.RWMutex{}
cache := map[string]*jwt.Token{}

return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
authheader := r.Header.Get("Authorization")
if authheader == "" || !strings.HasPrefix(authheader, "Bearer ") {
http.Error(rw, "Use JWT Authentication", http.StatusUnauthorized)
return
}

rawtoken := authheader[len("Bearer "):]
cacheLock.RLock()
token, ok := cache[rawtoken]
cacheLock.RUnlock()
if ok && token.Claims.Valid() == nil {
next.ServeHTTP(rw, r)
return
}

// The actual token is ignored for now.
// In case expiration and so on are specified, the Parse function
// already returns an error for expired tokens.
var err error
token, err = jwt.Parse(rawtoken, func(t *jwt.Token) (interface{}, error) {
if t.Method != jwt.SigningMethodEdDSA {
return nil, errors.New("only Ed25519/EdDSA supported")
}

return publicKey, nil
})
if err != nil {
http.Error(rw, err.Error(), http.StatusUnauthorized)
return
}

cacheLock.Lock()
cache[rawtoken] = token
cacheLock.Unlock()

// Let request through...
next.ServeHTTP(rw, r)
})
}

0 comments on commit 5ca66ae

Please sign in to comment.