Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create some acceptance tests. #315

Closed
tomprince opened this issue Jul 16, 2014 · 9 comments · Fixed by #897
Closed

Create some acceptance tests. #315

tomprince opened this issue Jul 16, 2014 · 9 comments · Fixed by #897

Comments

@tomprince
Copy link
Contributor

This should at least include running through the tutorial, to ensure that it works.

@itamarst
Copy link
Contributor

itamarst commented Sep 8, 2014

I added links to some potentially relevant tools in #577.

@exarkun
Copy link
Contributor

exarkun commented Sep 30, 2014

We've previously discussed not duplicating the steps documented in the tutorial as a requirement for this issue. In the interest of making some progress, we're going to drop that requirement for now. To resolve this issue we should have some kind of automated acceptance tests covering much or all of the same material as is covered in the tutorial but if we need to duplicate that material in the implementation of the acceptance tests, okay.

@exarkun
Copy link
Contributor

exarkun commented Sep 30, 2014

Some rough notes from a discussion about how to go about implementing this:

  • acceptance test run in docker - each node is run in a docker container (unlike tutorial which has VM per node)
    • requirement: docker-in-docker
    • requirement: zfs from inside docker
    • question: how separate are different storage pools on one machine?
    • limitation: doesn't exactly test our vagrant image
  • use packer to build vagrant image and docker image
  • checks out flocker from git

Out of scope:

  • doesn't discover packaging bugs
    • run the test suite against a package install to find those

@itamarst
Copy link
Contributor

Also need to be able to configure the name of the pool for a Flocker install, instead of current hard coding of "flocker".

@itamarst
Copy link
Contributor

As first pass we should assume we're running on a Linux host machine with ZFS and Docker installed.

@tomprince
Copy link
Contributor Author

I have in progress code to build a tutorial image, and then start it up, on buildbot. It would be easy to then run some code against those nodes.

@adamtheturtle adamtheturtle self-assigned this Oct 1, 2014
@adamtheturtle
Copy link
Contributor

See http://blog.docker.com/2013/09/docker-can-now-run-within-docker/ about running Docker in Docker

@adamtheturtle
Copy link
Contributor

Tom by tutorial image you mean Vagrant image, right?

@tomprince
Copy link
Contributor Author

The tutorial vagrant image, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants