[FLOC-4421] Diffing of objects #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empt-implementation
…empt-implementation
…mpt-implementation
| @@ -0,0 +1,247 @@ | |||
| # Copyright ClusterHQ Inc. See LICENSE file for details. | |||
| # -*- test-case-name: flocker.control.test.test_diffing -*- | |||
|
|
|||
|
Thanks @sarum90 This looks great. I see now why the Node and Application pmaps make this so much easier. I noted some missing test coverage which we should probably address before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to just send Configuration and State diffs to all of the nodes, Flocker needs to have a mechanism to compute the diff between two different Configurations or two different States.
This Adds a generic "Diffs between pyrsistent objects" module, and adds a bunch of hypothesis strategies to generate deployments in order to assist in testing the diffing algorithm.