Gcrypt fix #142
Merged
Gcrypt fix #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read_server_reply first reads boothc header and then rest of packet which contains hmac info. This should go in memory right after boothc_header and not after full length of packet, because full length of packet already contains hmac info. Solution is to simply use length of header and not length of packet. Longer term and better solution would be to drop read_server_reply completely and use recv_auth which is used for everything else but attr set and delete. Signed-off-by: Jan Friesse <jfriesse@redhat.com>
When unknown hash is passed to gcry_md_get_algo_dlen 0 is returned. This value is then used for memcmp so wrong hmac might be accepted as correct. Signed-off-by: Jan Friesse <jfriesse@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reading of server_reply. Also properly check result of gcry_md_get_algo_dlen.
This two patches fixes CVE-2024-3049
Already preaproved by @clumens