OpenStack: Merge Vincent's changes and update agents for Pike #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't care about other services.
Everything we do (evacuate, force_down) is on nova-compute services, so there's no reason to list hypervisors; just directly look for nova-compute services. This matters as hypervisors are always FQDN, while nova service hosts can be short hostnames.
We were returning from the loop, while we want the rest of the code to still execute (in case there are multiple domains in nova). Also simplify the code...
We shouldn't check if the plug name contains the domain, but if it ends with the domain.
We already do the filtering on the server side.
…to vuntz-fix-domain
oalbrigt
reviewed
Sep 13, 2017
| RELEASE_VERSION="4.0.11" | ||
| BUILD_DATE="(built Wed Nov 12 06:33:38 EST 2014)" | ||
| REDHAT_COPYRIGHT="Copyright (C) Red Hat, Inc. 2004-2010 All rights reserved." | ||
| #END_VERSION_GENERATION |
There was a problem hiding this comment.
This section should be removed from both agents, as we've moved the essential part to lib/fencing.py to support reproducible builds.
https://github.com/ClusterLabs/fence-agents/pull/131/files#diff-94a84d829e5760b9a84e6d98bdba8fc4
|
CI fails due to changed metadata, so you should do a "make xml-upload" and commit the changes. |
|
For reference, here is the corresponding change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split needs to be timed with an equivalent change to NovaEvacuate