Invert the force-down/service disable order #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OpenStack Train we first observed that IHA was not working via https://bugzilla.redhat.com/show_bug.cgi?id=1760213 The reason for this is that nova has made the disabling of the compute service depend on the compute node being up via: https://review.opendev.org/#/c/654596/ By first calling force-down, the subsequence service-disable API call won't wait for the reachability of the compute node any longer and the whole operation has the same outcome. Tested this on an OSP Train environment and we correctly got Instance HA working again and we observed the VMs being restarted on the available compute nodes. Co-Authored-By: Luca Miccini <lmiccini@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenStack Train we first observed that IHA was not working via
https://bugzilla.redhat.com/show_bug.cgi?id=1760213
The reason for this is that nova has made the disabling of the compute
service depend on the compute node being up via:
https://review.opendev.org/#/c/654596/
By first calling force-down, the subsequence service-disable API
call won't wait for the reachability of the compute node any
longer and the whole operation has the same outcome.
Tested this on an OSP Train environment and we correctly
got Instance HA working again and we observed the VMs being
restarted on the available compute nodes.
While doing this change we also remove the code that
tries to fallback in case the force-down API is not available in
nova. We do this to simplify the code a bit, and we can do so
since that code landed upstream in Openstack Liberty (OSP8)
which has been unmaintained and EOLed for a long time now.
Co-Authored-By: Luca Miccini lmiccini@redhat.com