Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fence_aws: fixes to allow running outside of AWS network #534

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

oalbrigt
Copy link
Collaborator

@oalbrigt oalbrigt commented Mar 30, 2023

  • add --skip-race-check parameter to allow running outside of AWS network e.g. for openshift
  • fixed and improved logging logic
  • use --debug-file parameter for file logging

@oalbrigt oalbrigt force-pushed the fence_aws-fixes branch 3 times, most recently from dacfd6f to cacd166 Compare March 30, 2023 10:42
@gguifelixamz
Copy link
Contributor

@oalbrigt replacing "-verbose" with "--verbose-level" will cause backward compatibility issues? (i.e.: breaking where --verbose is being used?).

@oalbrigt
Copy link
Collaborator Author

@oalbrigt replacing "-verbose" with "--verbose-level" will cause backward compatibility issues? (i.e.: breaking where --verbose is being used?).

Yeah. I think I'll add a logfile parameter and rely on that instead of verbosity for this functionality.

- add --skip-race-check parameter to allow running outside of AWS
  network e.g. for openshift
- fixed and improved logging logic
- use --debug-file parameter for file logging
@oalbrigt
Copy link
Collaborator Author

@gguifelixamz I updated it to use -D/--debug-file, and keep the formatting.

@gguifelixamz
Copy link
Contributor

LGTM

@oalbrigt oalbrigt merged commit e1f54b1 into ClusterLabs:main Apr 11, 2023
@oalbrigt oalbrigt deleted the fence_aws-fixes branch April 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants