Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug / Feature Request: Cluster SBD Error'ing (when not present) #28

Closed
ashleyprimo opened this issue Oct 11, 2019 · 3 comments
Closed

Comments

@ashleyprimo
Copy link
Contributor

I have noticed that when operating the exporter on a machine that does not have sbd setup the following set of errors are seen repeatedly:

2019/10/11 15:14:12 [INFO]: Reading cluster SBD configuration..
2019/10/11 15:14:12 [ERROR] Could not open sbd config file open /etc/sysconfig/sbd: no such file or directory

There should maybe be a check such as

if _, err := os.Stat("/etc/sysconfig/sbd"); os.IsNotExist(err) {
	log.Println("[INFO]: SBD is not present... skipping.")
} else {

}

This would give a single output of 0000/00/00 00:00:00 [INFO]: SBD is not present... skipping. instead of continually repeating an error in the absence of sbd. :)

@MalloZup
Copy link
Contributor

@ashleyprimo ok I have looked at your PR. Make sense thx for this.

ashleyprimo pushed a commit to ashleyprimo/ha_cluster_exporter that referenced this issue Oct 11, 2019
stefanotorresi added a commit that referenced this issue Oct 14, 2019
Regarding Issue #28 - Fix SBD error in absence of SBD
@MalloZup
Copy link
Contributor

done

@MalloZup
Copy link
Contributor

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants