Add qdevice membership parsing and metric label #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #170
There is only one special case, we might need to handle:
ha_cluster_corosync_member_votes{local="false",node="Qdevice",node_id="0",qdevice=""} 1
when the qdevice is active
the table qdevice is empty so we create an empty metric.
I was thinking in order to avoid an empty metric we should populated the label
qdevice
withqdevice
for indicating that it is the qdevice.@gao-yan @nick-wang let me know what do you think