Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qdevice membership parsing and metric label #172

Merged
merged 3 commits into from
Aug 6, 2020

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented Aug 5, 2020

Fix #170

There is only one special case, we might need to handle:

ha_cluster_corosync_member_votes{local="false",node="Qdevice",node_id="0",qdevice=""} 1

when the qdevice is active

Quorum information
------------------
Date:             Thu Jul 16 12:40:44 2020
Quorum provider:  corosync_votequorum
Nodes:            2
Node ID:          1
Ring ID:          1/139
Quorate:          Yes

Votequorum information
----------------------
Expected votes:   3
Highest expected: 3
Total votes:      3
Quorum:           2  
Flags:            Quorate Qdevice 

Membership information
----------------------
    Nodeid      Votes    Qdevice Name
         1          1    A,V,NMW nfs01 (local)
         2          1    A,V,NMW nfs02
         0          1            Qdevice

the table qdevice is empty so we create an empty metric.

I was thinking in order to avoid an empty metric we should populated the label qdevice with qdevice for indicating that it is the qdevice.

@gao-yan @nick-wang let me know what do you think

Add support for parsing corosync membership parsing with qdevice enabled/disabled (issue n170)
Handle when Qdevice is active and add tests
@stefanotorresi
Copy link
Member

I was thinking in order to avoid an empty metric we should populated the label qdevice with qdevice for indicating that it is the qdevice.

Well, it's not really empty, you can see it's the Qdevice from the name! I don't think this is that special, after all.

@stefanotorresi stefanotorresi merged commit 7a7dbdc into ClusterLabs:master Aug 6, 2020
@stefanotorresi
Copy link
Member

thanks Dario!

@MalloZup
Copy link
Contributor Author

MalloZup commented Aug 6, 2020

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

corosync membership parsing with qdevice enabled
2 participants