fix cloned resource collection once and for all #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanotorresi
deleted the
fix-cloned-resources-collection-once-and-for-all
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of #191, fixes #193
This is a more generic solution which keeps the tracking of stopped resources even when they are cloned (#191 was a quick and dirty solution that removed the tracking altogether, and only for the clusterfs RA).
Pacemaker Clone Resources appear multiple times in
crm_mon; since the main discriminator field is the node, and that's missing when a resource is stopped, the cloned and stopped entries will appear multiple times in thecrm_monoutput, with the exact same fields and values: this is a problem for the Prometheus SDK, which doesn't expect duplicate metrics over the course of a single collection cycle.Collaterally, this PR also removes the
downloadmake target, which was a vestigial thing required when using old Go versions.