Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document metrics specification (initial effort and skeleton, pacemaker) #58

Merged
merged 2 commits into from
Oct 17, 2019

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented Oct 17, 2019

Desc:

You can navigate throught the doc here;

https://github.com/MalloZup/ha_cluster_exporter/tree/documentation-metric

What add this pr:

we add a new (WIP) metrics documentation page.

For each metric, we order them by component and we specify the possible values

Also we add this in the main readme.md at the end of feature point.

extra:

this PR just cover pacemaker metrics.
We can cover doc of other in other prs

@MalloZup MalloZup changed the title WIP: document metrics specification document metrics specification (initial effort and skeleton, pacemaker) Oct 17, 2019
@MalloZup MalloZup force-pushed the documentation-metric branch 2 times, most recently from 1143951 to 0d8880f Compare October 17, 2019 10:12
@MalloZup
Copy link
Contributor Author

MalloZup commented Oct 17, 2019

@gao-yan @ayoub-belarbi cc ( i couldn't add you as reviewer)

Copy link
Member

@gao-yan gao-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, Dario! Just a few comments.

doc/metric_spec.md Show resolved Hide resolved
doc/metric_spec.md Outdated Show resolved Hide resolved
doc/metric_spec.md Outdated Show resolved Hide resolved
doc/metric_spec.md Outdated Show resolved Hide resolved
doc/metric_spec.md Outdated Show resolved Hide resolved
doc/metric_spec.md Outdated Show resolved Hide resolved
doc/metric_spec.md Show resolved Hide resolved
doc/metric_spec.md Outdated Show resolved Hide resolved
doc/metric_spec.md Show resolved Hide resolved
@MalloZup
Copy link
Contributor Author

I'm merging this PR thx for review.

I will open some follow-up issue we have regarding the docs

@MalloZup MalloZup merged commit 46aee69 into ClusterLabs:master Oct 17, 2019

```ha_cluster_node_resources{managed="true",node_name="1b115",resource_name="cluster_md",role="started",status="active"} 1```

The metric will absent and not `0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"will be absent" ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants