-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document metrics specification (initial effort and skeleton, pacemaker) #58
Conversation
1143951
to
0d8880f
Compare
0d8880f
to
6209c20
Compare
@gao-yan @ayoub-belarbi cc ( i couldn't add you as reviewer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, Dario! Just a few comments.
f19837e
to
3b6e564
Compare
I'm merging this PR thx for review. I will open some follow-up issue we have regarding the docs |
|
||
```ha_cluster_node_resources{managed="true",node_name="1b115",resource_name="cluster_md",role="started",status="active"} 1``` | ||
|
||
The metric will absent and not `0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"will be absent" ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doh!
Desc:
You can navigate throught the doc here;
https://github.com/MalloZup/ha_cluster_exporter/tree/documentation-metric
What add this pr:
we add a new (WIP) metrics documentation page.
For each metric, we order them by component and we specify the possible values
Also we add this in the main readme.md at the end of feature point.
extra:
this PR just cover pacemaker metrics.
We can cover doc of other in other prs