Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page to exporter #73

Merged
merged 1 commit into from Oct 25, 2019
Merged

Conversation

ashleyprimo
Copy link
Contributor

This is a PR per issue #69 to add a landing page to the exporter instead of a 404 error page 馃槂 (sorry for the failed previous PR)

ha_cluster_exporter.go Outdated Show resolved Hide resolved
ha_cluster_exporter.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@MalloZup
Copy link
Contributor

@ashleyprimo can we have a screenshot attached to see how it looks like?

optional: can you check why is travis failing? thx sofar!

@MalloZup
Copy link
Contributor

#74

@ashleyprimo
Copy link
Contributor Author

@MalloZup

@ashleyprimo can we have a screenshot attached to see how it looks like?

You can take a look at a preview image here, https://ashleyprimo.com/uploads/JEwPXOU3iJDAy1K0raaq.png - It's fairly simple however happy to make changes as needed. :)

In regards to the Travis CI failure, preliminary checks suggest that it's related to lack of gofmt -w . of my code; the diff after doing so is:

diff --git a/ha_cluster_exporter.go b/ha_cluster_exporter.go
index fce2e44..5e51291 100644
--- a/ha_cluster_exporter.go
+++ b/ha_cluster_exporter.go
@@ -114,4 +114,4 @@ func main() {
        http.Handle("/metrics", promhttp.Handler())
        log.Infoln("Serving metrics on port", *portNumber)
        log.Fatal(http.ListenAndServe(fmt.Sprintf(":%s", *portNumber), nil))
-}
\ No newline at end of file
+}
diff --git a/vendor/github.com/sirupsen/logrus/terminal_check_bsd.go b/vendor/github.com/sirupsen/logrus/terminal_check_bsd.go
index 3c4f43f..ff6ff7b 100644
--- a/vendor/github.com/sirupsen/logrus/terminal_check_bsd.go
+++ b/vendor/github.com/sirupsen/logrus/terminal_check_bsd.go
@@ -10,4 +10,3 @@ func isTerminal(fd int) bool {
        _, err := unix.IoctlGetTermios(fd, ioctlReadTermios)
        return err == nil
 }
-

@MalloZup
Copy link
Contributor

@ashleyprimo nice thx!
LGTM we will merge this PR after we release the current master.

good work!

@MalloZup MalloZup merged commit a9b67ce into ClusterLabs:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants