Add SBD devices count metric #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloZup
reviewed
Nov 12, 2019
MalloZup
reviewed
Nov 12, 2019
MalloZup
suggested changes
Nov 12, 2019
There was a problem hiding this comment.
@stefanotorresi great pr. I have just added 2 comments.
1 is regarding doc but we can even omit.
The only thing is that I would like we comment shortly the new regex of what is doing since is more tricky.
A part of fhat looks great 👍
MalloZup
reviewed
Nov 12, 2019
stefanotorresi
force-pushed
the
feature/90-sbd-dev-count-metric
branch
from
bf94632
to
517ef0b
Compare
|
@MalloZup rebased! |
MalloZup
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90