Fix: pengine: disable migration for versioned resources #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-tsiglyar
force-pushed
the
versioned-migration
branch
from
dfbad90
to
36a6347
Compare
igor-tsiglyar
force-pushed
the
versioned-migration
branch
from
36a6347
to
0bec2ae
Compare
| /* by default, we want baremetal remote-nodes to be able | ||
| * to float around the cluster without having to stop all the | ||
| * resources within the remote-node before moving. Allowing | ||
| * migration support enables this feature. If this ever causes | ||
| * problems, migration support can be explicitly turned off with | ||
| * allow-migrate=false. */ | ||
| * allow-migrate=false. | ||
| * We don't support migration for versioned resources, though. */ |
There was a problem hiding this comment.
FYI baremetal_remote_node is for the ocf:pacemaker:remote resource itself, so it will never have versioned parameters. No harm in double-checking here, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resolution of the issue discussed in #1063.