Low: Fixed crm_report to work when using custom paths in autoconf. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix uses the @localstatedir@ and @execdir@ paths as setup by autoconf.
Additionally it properly tries to find the corosync.conf file. I feel as though this change might be what will be debated. I chose against using $depth as the default "--maxdepth 5" doesn't suffice on my systems. Additionally my rationale was, if it's going to try to find something and warns that it might take a while, why stop at depth 5.
Perhaps the best option would be to allow for the depth to be passed as a parameter and use it consistently.