Fix attrd race condition when shutting down #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clumens, can you review this when you get a chance? Thanks |
This addresses a race condition that can occur when the DC and the attribute writer are different nodes, and shutting down at the same time. When the DC controller leaves its Corosync process group, the remaining nodes erase its transient node attributes (including "shutdown") from the CIB. However if the (former) DC's attrd is still up, it can win the attribute writer election called after the original writer leaves. As the election winner, it writes out all its attributes to the CIB, including "shutdown". The next time it rejoins the cluster, it will be immediately shut down. Fixes T138
This makes it more obvious that each caller has considered whether to include shutdown requests in its check.
clumens
reviewed
Aug 3, 2023
|
Updated for review and threw one more commit on top |
clumens
reviewed
Aug 3, 2023
|
Patches look good. ctslab is looking good through 65 runs, including multiple NearQuorumPoint runs. I have it set to run 150 tests, so I guess we'll know tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.