Heartbeat 3.0.6 compatibility #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACTIVE is defined to be MEMBER anyways: include/crm/cluster.h:#define CRM_NODE_ACTIVE CRM_NODE_MEMBER Don't confuse the reader of the code by implying it was something different.
Get rid of some spurious error messages, and speed up shutdown, even if the connection to the stonith daemon failed.
The rest of the code deals in "online" and "offline", not "join" and "leave". Need to map these states, or the rest of the code won't work properly.
The "set_bit()" function used here actually deals with masks, not bit numbers. The "flag" argument should in fact be plural: flags. These proc flag bits are not always set one at a time, but for example as "crm_proc_crmd | crm_proc_cpg", and not necessarily cleared with the same combination. Ignoring to-be-set flags just because *some* of the flag bits are already set is clearly a bug, and may be the reason for stale process cache information.
Don't optimistically assume that peer client processes are alive, or that a node that can talk to us is in fact member of the same ccm partition. Whenever ccm tells us about a new membership, *ask* for peer client process status.
Since the introduction of the additional F_TYPE messages T_STONITH_NOTIFY and T_STONITH_TIMEOUT_VALUE, and their use as message types in global heartbeat cluster messages, stonith-ng was broken on the heartbeat cluster stack. When delegation was made the default, and the result could only be reaped by listening for the T_STONITH_NOTIFY message, no-one (but stonithd itself) would ever notice successful completion, and stonith would be re-issued forever. Registering callbacks for these F_TYPE fixes these hung stonith and stonith_admin operations on the heartbeat cluster stack.
…artbeat In ha_msg_dispatch(), change from rcvmsg() to readmsg(). rcvmsg() is internally simply a wrapper around readmsg(), which silently deletes messages without matching callback. Use readmsg() directly here. It will only return unprocessed (by callbacks) messages, so log a warning, notice or debug message depending on message header information, and ha_msg_del() it ourselves.
Heartbeat 3.0.6 now may spawn the pengine directly, and will announce this in the environment -- I introduced the setting "crmd_spawns_pengine". This improves shutdown behavior. Otherwise I regularly find an orphaned pengine process after pacemaker shutdown.
This is for the "Why does my resource not start?" guys who forgot to remove the limiting target-role setting. Report target role (unless "Started", which is the default anyways), if it limits our abilities (Slave, Stopped), or if it differs from the current status.
Add back the fake meta data for old style class heartbeat resource agents # crm_resource --show-metadata heartbeat:Something It was lost during the lrmd rewrite.
|
Oops. Some "summary" changed, obviously, because of the new (target-role:Stopped) annotation. |
The lrmd regression tests are unhappy with double quotes. Also, single quotes do not need to be escaped, now it looks better, too :-)
Semantics: - /etc/ha.d/resource.d/* - take optional positional arguments - start/stop exit codes as lsb, - status exit code ignored, status determined by matching stdout against "stopped", "not running", resp. "running", "OK", empty or no match is equivalent to not running.
|
Ok, added test case summary fixes for the target-role annotation, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.