overhaul pcs property config | describe | defaults commands

CHANGELOG.md

@@ -5,7 +5,13 @@
 ### Added
 - Automatic restarts of the Puma web server in the legacy Ruby daemon to reduce
   its memory footprint ([rhbz#2189958])
+- Add `pcs property defaults` and `pcs property describe` CLI commands
+- Support for output formats `json` and `cmd` to property config command
+  ([rhbz#2166289])
+- Commands `pcs resource describe` and `pcs stonith describe` print detailed
+  info about resource options (data type or allowed values, default value)
 
+[rhbz#2166289]: https://bugzilla.redhat.com/show_bug.cgi?id=2166289
 [rhbz#2189958]: https://bugzilla.redhat.com/show_bug.cgi?id=2189958
 
 

mypy.ini

@@ -2,6 +2,10 @@
 mypy_path = ./pcs/bundled/packages
 
 # Modules and packages with full support have more strict checks enabled
+[mypy-pcs.cli.cluster_property]
+disallow_untyped_defs = True
+disallow_untyped_calls = True
+
 [mypy-pcs.cli.common.printable_tree]
 disallow_untyped_defs = True
 disallow_untyped_calls = True

pcs/Makefile.am

@@ -23,9 +23,11 @@ EXTRA_DIST		= \
 			  cli/booth/command.py \
 			  cli/booth/env.py \
 			  cli/booth/__init__.py \
-			  cli/cluster/command.py \
 			  cli/cluster/__init__.py \
-			  cli/cluster_property.py \
+			  cli/cluster/command.py \
+			  cli/cluster_property/__init__.py \
+			  cli/cluster_property/command.py \
+			  cli/cluster_property/output.py \
 			  cli/common/capabilities.py \
 			  cli/common/completion.py \
 			  cli/common/env_cli.py \
@@ -103,13 +105,14 @@ EXTRA_DIST		= \
 			  common/interface/__init__.py \
 			  common/node_communicator.py \
 			  common/pacemaker/__init__.py \
+			  common/pacemaker/cluster_property.py \
 			  common/pacemaker/defaults.py \
 			  common/pacemaker/nvset.py \
 			  common/pacemaker/resource/__init__.py \
 			  common/pacemaker/resource/bundle.py \
 			  common/pacemaker/resource/clone.py \
-			  common/pacemaker/resource/list.py \
 			  common/pacemaker/resource/group.py \
+			  common/pacemaker/resource/list.py \
 			  common/pacemaker/resource/operations.py \
 			  common/pacemaker/resource/primitive.py \
 			  common/pacemaker/resource/relations.py \
@@ -322,7 +325,6 @@ EXTRA_DIST		= \
 			  node.py \
 			  pcsd.py \
 			  pcs_internal.py \
-			  prop.py \
 			  qdevice.py \
 			  quorum.py \
 			  resource.py \

pcs/acl.py

@@ -1,7 +1,4 @@
-from pcs import (
-    prop,
-    utils,
-)
+from pcs.cli.cluster_property.output import PropertyConfigurationFacade
 from pcs.cli.common.errors import CmdLineInputError
 from pcs.cli.reports.output import warn
 from pcs.common.str_tools import indent
@@ -36,10 +33,14 @@ def acl_config(lib, argv, modifiers):
     modifiers.ensure_only_supported("-f")
     if argv:
         raise CmdLineInputError()
-    properties = utils.get_set_properties(
-        defaults=prop.get_default_properties()
+
+    properties_facade = PropertyConfigurationFacade.from_properties_dtos(
+        lib.cluster_property.get_properties(),
+        lib.cluster_property.get_properties_metadata(),
+    )
+    acl_enabled = properties_facade.get_property_value_or_default(
+        "enable-acl", ""
     )
-    acl_enabled = properties.get("enable-acl", "").lower()
     if is_true(acl_enabled):
         print("ACLs are enabled")
     else: