ethmonitor now up to snuff #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery little checking. Changed to using sysfs as much as possible, vs. grepping the output of the ip command. Sysfs is more reliable.
|
Closing as the contributor never offered constructive criticism or clean patches. |
Closed
|
You may want to consider removing the ethmonitor script in your project, it doesn't actually work. I don't have the time to go back and submit individual pull requests, but the ethmonitor that is there now will always return true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check now properly checks for a real, active (with link) Ethernet interface, vs. just checking to see if the interface is defined. It still has two fall-through tests if the first one fails for whatever reason.