Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6. #152

Merged
merged 6 commits into from Oct 15, 2012

Conversation

Projects
None yet
4 participants
Contributor

kskmori commented Oct 12, 2012

This is the revised patches of the pull request #97 for merging to the upstream.


Open issues:

the issues below are not covered by this pull request. Those would be addressed separately by another patch or pull request.

A patch is proposed (and it works) but there is an alternative way which is considered more preferable. I will look into it more but I would appreciate for any comments.

I will look into this later too.

Thanks,

kskmori added some commits Oct 5, 2012

@kskmori kskmori Dev: remove symlinks on make uninstall 1d8cc2c
@kskmori kskmori Low: IPaddr2: ocft script updated before changes
IPaddr2v4 is added to make it clear what is going to be changed
by replacing the findif binary with findif.sh.
e1b65d2
@kskmori kskmori High: IPaddr2: replace the findif binary by findif.sh
Acknowledgement
  Thanks to Tomo Nozawa-san for his hard work for writing and testing the series of patches for IPv6 support.
  Thanks to Lars Ellenberg for the first findif.sh implementation.
34d935c
@kskmori kskmori High: add send_ua binary for IPv6 support in IPaddr2 17d9f6a
@kskmori kskmori High: IPaddr2: add IPv6 support 4028fb6
@kskmori kskmori Low: IPaddr2: ocft test cases updated for IPv4/IPv6 374252c
Contributor

dmuhamedagic commented Oct 12, 2012

Great work!

@dmuhamedagic dmuhamedagic added a commit that referenced this pull request Oct 15, 2012

@dmuhamedagic dmuhamedagic Merge pull request #152 from kskmori/IPaddr2-dualstack-pullreq
IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6.
1dd137a

@dmuhamedagic dmuhamedagic merged commit 1dd137a into ClusterLabs:master Oct 15, 2012

Contributor

jnpkrn commented Oct 15, 2012

Just a quick look, is findif.sh not set as executable for a reason?

Contributor

jnpkrn commented Oct 15, 2012

^ ignore please :)

Contributor

dmuhamedagic commented Oct 15, 2012

On Mon, Oct 15, 2012 at 09:20:22AM -0700, jnpkrn wrote:

Just a quick look, is findif.sh not set as executable for a reason?

findif.sh should be sourced from IPaddr2 and therefore shouldn't
be executable.

Contributor

grueni commented on 1d8cc2c Oct 19, 2012

Coud you please have a look at this pull request.
I did exactly the same and more.
I am wondering why my pull request is ignored.
#138.

Andreas

Contributor

kskmori commented Oct 26, 2012

@dmuhamedagic : Could you take a look at and merge this pull request too?

As Andreas says, my commit 1d8cc2c can be superseded by this pull request.
I was not aware that the same fix was in this when I wrote it.

Thanks,

Coud you please have a look at this pull request.
I did exactly the same and more.
I am wondering why my pull request is ignored.
ClusterLabs/resource-agents#138.

Andreas

Contributor

dmuhamedagic commented Oct 30, 2012

@kskmori: @fabbione was taking care of the configure bits and he specifically asked to keep it that way. I guess he'll take a look soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment