Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6. #152

Merged
merged 6 commits into from
Oct 15, 2012

Conversation

kskmori
Copy link

@kskmori kskmori commented Oct 12, 2012

This is the revised patches of the pull request #97 for merging to the upstream.


Open issues:

the issues below are not covered by this pull request. Those would be addressed separately by another patch or pull request.

A patch is proposed (and it works) but there is an alternative way which is considered more preferable. I will look into it more but I would appreciate for any comments.

I will look into this later too.

Thanks,

Keisuke MORI added 6 commits October 12, 2012 13:56
IPaddr2v4 is added to make it clear what is going to be changed
by replacing the findif binary with findif.sh.
Acknowledgement
  Thanks to Tomo Nozawa-san for his hard work for writing and testing the series of patches for IPv6 support.
  Thanks to Lars Ellenberg for the first findif.sh implementation.
@dmuhamedagic
Copy link
Contributor

Great work!

dmuhamedagic added a commit that referenced this pull request Oct 15, 2012
IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6.
@dmuhamedagic dmuhamedagic merged commit 1dd137a into ClusterLabs:master Oct 15, 2012
@jnpkrn
Copy link
Contributor

jnpkrn commented Oct 15, 2012

Just a quick look, is findif.sh not set as executable for a reason?

@jnpkrn
Copy link
Contributor

jnpkrn commented Oct 15, 2012

^ ignore please :)

@dmuhamedagic
Copy link
Contributor

On Mon, Oct 15, 2012 at 09:20:22AM -0700, jnpkrn wrote:

Just a quick look, is findif.sh not set as executable for a reason?

findif.sh should be sourced from IPaddr2 and therefore shouldn't
be executable.

@kskmori
Copy link
Author

kskmori commented Oct 26, 2012

@dmuhamedagic : Could you take a look at and merge this pull request too?

As Andreas says, my commit 1d8cc2c can be superseded by this pull request.
I was not aware that the same fix was in this when I wrote it.

Thanks,

Coud you please have a look at this pull request.
I did exactly the same and more.
I am wondering why my pull request is ignored.
#138.

Andreas

@dmuhamedagic
Copy link
Contributor

@kskmori: @fabbione was taking care of the configure bits and he specifically asked to keep it that way. I guess he'll take a look soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants