-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6. #152
IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6. #152
Conversation
IPaddr2v4 is added to make it clear what is going to be changed by replacing the findif binary with findif.sh.
Acknowledgement Thanks to Tomo Nozawa-san for his hard work for writing and testing the series of patches for IPv6 support. Thanks to Lars Ellenberg for the first findif.sh implementation.
Great work! |
IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6.
Just a quick look, is findif.sh not set as executable for a reason? |
^ ignore please :) |
On Mon, Oct 15, 2012 at 09:20:22AM -0700, jnpkrn wrote:
findif.sh should be sourced from IPaddr2 and therefore shouldn't |
@dmuhamedagic : Could you take a look at and merge this pull request too? As Andreas says, my commit 1d8cc2c can be superseded by this pull request. Thanks,
|
This is the revised patches of the pull request #97 for merging to the upstream.
Open issues:
the issues below are not covered by this pull request. Those would be addressed separately by another patch or pull request.
A patch is proposed (and it works) but there is an alternative way which is considered more preferable. I will look into it more but I would appreciate for any comments.
I will look into this later too.
Thanks,