IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 12, 2012 13:56
IPaddr2v4 is added to make it clear what is going to be changed by replacing the findif binary with findif.sh.
Acknowledgement Thanks to Tomo Nozawa-san for his hard work for writing and testing the series of patches for IPv6 support. Thanks to Lars Ellenberg for the first findif.sh implementation.
|
Great work! |
dmuhamedagic
added a commit
that referenced
this pull request
Oct 15, 2012
IPaddr2: Proposal patch to support the dual stack of IPv4 and IPv6.
|
Just a quick look, is findif.sh not set as executable for a reason? |
|
^ ignore please :) |
|
On Mon, Oct 15, 2012 at 09:20:22AM -0700, jnpkrn wrote:
findif.sh should be sourced from IPaddr2 and therefore shouldn't |
|
@dmuhamedagic : Could you take a look at and merge this pull request too? As Andreas says, my commit 1d8cc2c can be superseded by this pull request. Thanks,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the revised patches of the pull request #97 for merging to the upstream.
Open issues:
the issues below are not covered by this pull request. Those would be addressed separately by another patch or pull request.
A patch is proposed (and it works) but there is an alternative way which is considered more preferable. I will look into it more but I would appreciate for any comments.
I will look into this later too.
Thanks,