podman: workaround race during container creation #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR created, I'm still verifying the last revision of this patch locally on my environment. |
cjeanner
reviewed
Jun 16, 2021
| # runtime configures the container. If that happens, recreate | ||
| # the container as long as we get the same error code or | ||
| # until start timeout preempts us. | ||
| while [ $rc -eq 127 ] && (echo "$out" | grep -q "cgroup.*scope not found") ; do |
There was a problem hiding this comment.
shouldn't we have some limit here, to prevent endless loop? It shouldn't happen, but some more security wouldn't hurt.
There was a problem hiding this comment.
Pacemaker itself preempts this infinite loop as soon as the start operation timeout is reached. This is usually the idiom we use in the resource agents to loop while we're allowed.
|
OK I verified locally that this patch recovers from that race: |
podman and OCI runtime have a race that sometimes causes a container to fail to be created and run [1] if the cgroup to be used is not available yet. When that happens, try to recreate it until it succeeds or the start timeout is reached. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1972209
|
I just pushed a new revision to get rid of a spurious trailing whitespace, but the patch is still the same so it should be good to go. |
|
LGTM. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman and OCI runtime have a race that sometimes causes
a container to fail to be created and run [1] if the
cgroup to be used is not available yet. When that happens,
try to recreate it until it succeeds or the start
timeout is reached.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1972209