High: Xen: retry domain lookup in repeating monitor and stop #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the guest is rebooting, it may completely disappear from the list of defined guests, thus xm/xen-list would return with not running. Apparently, this period lasts only for a second or two. It is easily reproducible by rebooting the guest. The effect is that a guest can be started on two nodes in parallel or even twice on the same node thus resulting in guest's filesystems corrupted. In both stop and repeating monitor actions, if we encounter no domain (OCF_NOT_RUNNING), we keep trying for the next 5 seconds. The impact of this patch is that when stopping a non-existent domain or unexpected disappearance of a running domain there will be an extra 5 second delay. This should be repaired within the xen domain.
dmuhamedagic
added a commit
that referenced
this pull request
Oct 2, 2013
High: Xen: retry domain lookup in repeating monitor and stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the guest is rebooting, it may completely disappear from the
list of defined guests, thus xm/xen-list would return with not
running. Apparently, this period lasts only for a second or two.
It is easily reproducible by rebooting the guest.
The effect is that a guest can be started on two nodes in
parallel or even twice on the same node thus resulting in guest's
filesystems corrupted.
In both stop and repeating monitor actions, if we encounter no
domain (OCF_NOT_RUNNING), we keep trying for the next 5 seconds.
The impact of this patch is that when stopping a non-existent
domain or unexpected disappearance of a running domain there will
be an extra 5 second delay.
This should be repaired within the xen domain.