Added sg_persist resource agent and ocft for it. #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2014 17:22
sg_psersist is a Resource agent that implements SPC-3 Persistent Reservations (contribution from Evgeny Nifontov). Customers with an active-passive storage setup using MD-raid1 need to ensure, that the MD device is only activated on one system at a time. While this is clearly possible with the existing Raid1 RA in SLEHA-11, there is still the possibility that crazy system administrators assemble such devices manually from the command line, leading to a complete data-loss as a result... There exists an implementation of a resource agent around the "sg_persist" Utility from the sg3_utils package. The sg_persist RA is just based on the sg3_utils tools. It works as a Master/Slave resource. It registers a reservation key for devices when the resource starts and holds reservation when the resource promotes to be a Master. There exist only one Master in case of the reservation type is 1/3/5/6 and can have multi Masters in case of the reservation type is 7/8. Signed-off-by: Evgeny Nifontov Signed-off-by: Liuhua Wang <lwang@suse.com>
| # OCF Resource Agent compliant PERSISTENT SCSI RESERVATION resource script. | ||
| # | ||
| # | ||
| # Copyright (c) 2011 Evgeny Nifontov, All Rights Reserved. |
There was a problem hiding this comment.
Liuhua, I think you should add yourself to the copyright list here too.
| return $OCF_NOT_RUNNING | ||
| fi | ||
|
|
||
| if [ ${#RESERVED_DEVS[*]} -gt 0 ] |
There was a problem hiding this comment.
I may be completely wrong here, but should we not consider the device only reserved/registered if we actually own the minimum number of devices, not already with a single one? I admit I've not thought this through completely.
|
@lhwang, would it be possible that you rebase this request and also add any additional patches? Thanks! And many thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sg_psersist is a Resource agent that implements SPC-3 Persistent
Reservations (contribution from Evgeny Nifontov).
Customers with an active-passive storage setup using MD-raid1 need
to ensure, that the MD device is only activated on one system at a
time. While this is clearly possible with the existing Raid1 RA in
SLEHA-11, there is still the possibility that crazy system
administrators assemble such devices manually from the command line,
leading to a complete data-loss as a result...
There exists an implementation of a resource agent around the "sg_persist"
Utility from the sg3_utils package. The sg_persist RA is just based on
the sg3_utils tools. It works as a Master/Slave resource. It registers a
reservation key for devices when the resource starts and holds reservation
when the resource promotes to be a Master. There exist only one Master
in case of the reservation type is 1/3/5/6 and can have multi Masters
in case of the reservation type is 7/8.
Signed-off-by: Evgeny Nifontov
Signed-off-by: Liuhua Wang lwang@suse.com