Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xen RA to use xl instead of the deprecated xm #440

Merged
merged 4 commits into from Aug 14, 2014

Conversation

krig
Copy link
Contributor

@krig krig commented Jun 13, 2014

First commit replaces the use of the xm command line tool with xl.

For more details, see:

Also comes with a second commit which cleans up trailing whitespace in the RA.

@l-mb
Copy link
Contributor

l-mb commented Jun 13, 2014

Yes, I'd also prefer if the RA stayed compatible with both xl and xm. (That would allow us to keep updating on older releases as well.)

@krig
Copy link
Contributor Author

krig commented Jun 13, 2014

Updated to fall back to using xm if xl is not available

@dmuhamedagic
Copy link
Contributor

Thanks! Let's just hope that xl really has the same semantics as xm.

@krig
Copy link
Contributor Author

krig commented Jun 13, 2014

The syntax seems to be the same (from some quick testing I did), but there could probably be subtle differences in semantics. But I think that can be true of any version upgrade.. I guess we'll see. :)

@krig
Copy link
Contributor Author

krig commented Jun 24, 2014

After talking to people more knowledgeable about Xen, it turns out that migrating from the xm tools to xl is decidedly non-trivial:

xl doesn't have any concept of Managed Domains, which means that xl list fails if the vm is not running.

The best solution seems to be to make people migrate to the VirtualDomain RA rather than trying to get the Xen RA to work with xl.

@dmuhamedagic
Copy link
Contributor

I wonder why did Xen replace xm with xl then. It's a pain to manage dropping features which were working.

@krig
Copy link
Contributor Author

krig commented Jun 24, 2014

Yes. :(

The xm command line tool has been deprecated in favor of the xl
toolstack.
For more information, see:
  - http://wiki.xen.org/wiki/MigrationGuideToXen4.1
  - http://wiki.xen.org/wiki/XL#Upgrading_from_xend

Use xl if available, else fall back on using xm.
Clean up trailing whitespace, and don't use ! as
heredoc delimiter as some editors don't handle it properly.
@krig
Copy link
Contributor Author

krig commented Aug 5, 2014

Updated with proper quoting around name parameter in call to $xentool create.

@krig
Copy link
Contributor Author

krig commented Aug 14, 2014

Now that there is a passing ocft test for this updated agent, any chance of merging?

@dmuhamedagic
Copy link
Contributor

Yes, sure, thanks!

dmuhamedagic added a commit that referenced this pull request Aug 14, 2014
Update Xen RA to use xl instead of the deprecated xm
@dmuhamedagic dmuhamedagic merged commit e6a5ab4 into ClusterLabs:master Aug 14, 2014
@krig
Copy link
Contributor Author

krig commented Aug 14, 2014

Thanks!

@krig krig deleted the xen-ra branch August 14, 2014 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants