IPaddr2: add support for same ip/netmask on different interfaces #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 25, 2012 21:53
Signed-off-by: Felix Bolte <felix.bolte@zimory.com>
Signed-off-by: Felix Bolte <felix.bolte@zimory.com>
Signed-off-by: Felix Bolte <felix.bolte@zimory.com>
|
Many thanks for the effort! |
dmuhamedagic
added a commit
that referenced
this pull request
Apr 15, 2012
IPaddr2: add support for same ip/netmask on different interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are some (rare) use cases where you need to attach the same IP address on different interfaces ... later on that could be handled by policy routing
at the moment find_interface() finds all interfaces with the same IP/netmask,
the second IPaddr2 resource would not attach its IP since ip_served() is already "ok" ... afterwards when using ip_stop(), it cannot delete it (error)
there was an ugly but possible workaround by changing the netmask on each resource having the same IP (/32, /31, /30), but that leads into problems on the main routing table ...
with this patch ip_served() would say "ok" only if the specified or found nic serves the wanted IP
however the unique constraint on "ip" was NOT removed ... it is just a warning and might be still ok to check for false configuration since this use case is a rare exception?