systemd: add resource-agents-deps target #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After= and Wants= will be added to pacemaker.service. |
beekhof
reviewed
May 4, 2017
| @@ -426,6 +426,18 @@ LVM_start() { | |||
| local vg=$1 | |||
| local clvmd=0 | |||
|
|
|||
| # systemd drop-in to stop process before storage services during | |||
| # shutdown/reboot | |||
| if ps -p 1 | grep -q systemd ; then | |||
There was a problem hiding this comment.
Looks like something we want a function for.
There was a problem hiding this comment.
From the man page of sd_booted():
Internally, this function checks whether the directory /run/systemd/system/ exists. A simple check like this can also be implemented trivially in shell or any other language.
|
On Wed, May 03, 2017 at 09:32:36PM -0700, Andrew Beekhof wrote:
> @@ -426,6 +426,18 @@ LVM_start() {
local vg=$1
local clvmd=0
+ # systemd drop-in to stop process before storage services during
+ # shutdown/reboot
+ if ps -p 1 | grep -q systemd ; then
Looks like something we want a function for.
IIRC, there's also a bunch of related tests in nfsserver. Best to
be done by somebody who's running systemd (I don't).
|
oalbrigt
force-pushed
the
systemd-deps-target
branch
from
6dd980d
to
89af981
Compare
|
He meant the drop-in, so I have now made a systemd_drop_in function that is being used by the 2 agents. |
|
Not sure what does "drop-in" mean. At any rate, what I meant is a function to test whether the system is running systemd. In nfsserver there's a test for systemctl existence which is not unequivocal (i.e. if systemctl exists doesn't necessarily mean that systemd is used to manage services).
|
|
drop-in is a systemd "override" file that can add After= or similar dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clvmd and LVM will create drop-ins on start to avoid nodes being fence during shutdown or reboot.