Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return to live version #329

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

Belonit
Copy link
Member

@Belonit Belonit commented Jan 5, 2024

No description provided.

Copy link
Contributor

@devo1929 devo1929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to point out that this should be a temporary fix. I think ideally, we want the updater to compare the contents of the version files for previous version and incoming version and delete and that are deemed "extra" from previous.

@Belonit
Copy link
Member Author

Belonit commented Jan 5, 2024

I'd like to point out that this should be a temporary fix. I think ideally, we want the updater to compare the contents of the version files for previous version and incoming version and delete and that are deemed "extra" from previous.

I think we can't delete "extra" files for the game's root directory, since it is difficult to determine what exactly is "extra"

@devo1929
Copy link
Contributor

devo1929 commented Jan 5, 2024

I'd like to point out that this should be a temporary fix. I think ideally, we want the updater to compare the contents of the version files for previous version and incoming version and delete and that are deemed "extra" from previous.

I think we can't delete "extra" files for the game's root directory, since it is difficult to determine what exactly is "extra"

I think the updater should have the ability to determine what's extra. I believe it already uses the current version file (before updating) and the version file that's IN the update to determine what files to pull down exactly during the update. I believe it does so by seeing which files exist in the new version file, but not the old as well as comparing hashes of files that exist in both. We should be able to create an additional check for files the exist in the old version file but NOT in the new and then delete what it finds.

@GrantBartlett GrantBartlett merged commit 579e44f into develop Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants