Skip to content

Commit

Permalink
feat: add new is{attribute} system and remove data- from attributtes
Browse files Browse the repository at this point in the history
  • Loading branch information
frankpagan committed Jul 28, 2021
1 parent 506c118 commit 6d16642
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion demo/page.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en" data-collection="" data-document_id="" data-prefix="" data-pass_id="wnd">
<html lang="en" collection="" document_id="" data-prefix="" data-pass_id="wnd">
<head>
<title>Modal | CocreateJS</title>

Expand Down
8 changes: 4 additions & 4 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@

<!-- CoCreate CSS CDN -->
<link rel="stylesheet" href="https://cdn.cocreate.app/latest/CoCreate.min.css" type="text/css" />
<link rel="stylesheet" href="https://ws.cocreate.app/docs.css" data-collection="apples" data-document_id="6069ff5042ef8ff5175a5c8d" name="css" type="text/css" />
<link rel="stylesheet" href="https://ws.cocreate.app/docs.css" collection="apples" document_id="6069ff5042ef8ff5175a5c8d" name="css" type="text/css" />
</head>

<body>

<nav class="nav display:flex align-items:center background:whitesmoke padding-top:10px padding-bottom:10px" data-main_content_id="content" data-scroll="sticky-nav,hide-nav" data-scroll_up="10" data-scroll_down="10" data-collection="components" data-document_id="60395ef42b3ac232657040fd"
<nav class="nav display:flex align-items:center background:whitesmoke padding-top:10px padding-bottom:10px" data-main_content_id="content" data-scroll="sticky-nav,hide-nav" data-scroll_up="10" data-scroll_down="10" collection="components" document_id="60395ef42b3ac232657040fd"
name="html">
</nav>
<sidenav id="menuL" class="cocreate-sidenav background:whitesmoke" data-main_content="content" sidenav-default_desktop="expanded" sidenav-default_tablet="offcanvas" sidenav-ontoggle_desktop="offcanvas" sidenav-ontoggle_tablet="expanded">
<menu data-collection="components" data-document_id="603717b07de7fb350ae9fec8" name="html"></menu>
<menu collection="components" document_id="603717b07de7fb350ae9fec8" name="html"></menu>
<div class="resizeHandler"></div>
</sidenav>
<main class="padding-top:15px padding:15px@lg@xl" data-main_content_id="content" id="cocreate-modal">
Expand Down Expand Up @@ -155,7 +155,7 @@ <h2 class="padding:5px_0px">Demo</h2>
<div class="svColumn">

<div class="svPanel">
<div data-realtime="false" data-collection="modules" data-document_id="5eefe30952c6e94c75fb5e3f" name="html" id="7" class="codemirror min-width:300px">
<div realtime="false" collection="modules" document_id="5eefe30952c6e94c75fb5e3f" name="html" id="7" class="codemirror min-width:300px">
</div>
</div>
<div class="svSplitter svHorizontal"> </div>
Expand Down
4 changes: 2 additions & 2 deletions src/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ Modal.prototype = {
iframe = this.__createContainer(this.headerArea, attributes['data-modal_iframe'] === "false" ? "div" : "iframe");
if (attributes['data-pass_to']) {
iframe.setAttribute('data-pass_id', attributes['data-pass_to']);
iframe.setAttribute('data-collection', "");
iframe.setAttribute('data-document_id', "");
iframe.setAttribute('collection', "");
iframe.setAttribute('document_id', "");
// iframe.setAttribute('data-request_id', uuid.generate());
}
if (attributes['data-pass_name']) {
Expand Down

0 comments on commit 6d16642

Please sign in to comment.