fix: remove data- from search attributes

CoCreate-app · Aug 13, 2021 · a2285a9 · a2285a9
1 parent 6598c69
commit a2285a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/demo/index.html b/demo/index.html
@@ -28,9 +28,9 @@
         name="selectField4" 
         placeholder="Single Options">
 
-        <input class="search-options" placeholder="Search" data-search_id="search_01" data-item_selector=".option">
+        <input placeholder="Search" search_id="search_01" search-selector=".option">
 
-        <ul class="options  overflow:overlay" data-search_id="search_01">
+        <ul class="options  overflow:overlay" search_id="search_01">
   				<li class="option"  data-value="value 1">
   				  <h3 >vale 1</h3>
   				  <h3 >value11</h3>

diff --git a/src/index.js b/src/index.js
@@ -7,7 +7,7 @@ const CoCreateSearch = {
 			return;
 		}
 
-		let search_elements = mainContainer.querySelectorAll('.search-options')
+		let search_elements = mainContainer.querySelectorAll('[search-selector]')
 		const self = this;
 		search_elements.forEach(element => {
 			self.searchEvent(element)
@@ -22,14 +22,14 @@ const CoCreateSearch = {
 	},
 
 	runSearchOfElement: function(searchElement, value) {
-		const search_id = searchElement.getAttribute('data-search_id')
-		const item_selector = searchElement.getAttribute('data-item_selector')
+		const search_id = searchElement.getAttribute('search_id')
+		const item_selector = searchElement.getAttribute('search-selector')
 
 		if (!search_id || !item_selector) {
 			return;
 		}
 
-		const items = document.querySelectorAll(`[data-search_id='${search_id}'] ${item_selector}`)
+		const items = document.querySelectorAll(`[search_id='${search_id}'] ${item_selector}`)
 
 		items.forEach((item) => {
 			const textContent = item.innerText