ENH: throw error when using glm_dsm with other correlation type than …

…Pearson
CoSMoMVPA · Aug 21, 2017 · a2c99e9 · a2c99e9
1 parent 4dce97b
commit a2c99e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/mvpa/cosmo_target_dsm_corr_measure.m b/mvpa/cosmo_target_dsm_corr_measure.m
@@ -246,6 +246,10 @@ function check_output(input_ds,output_ds_sa)
 
 
 function ds_sa=linear_regression_dsm(samples_pdist, params)
+    if ~strcmp(params.type,'Pearson')
+        error(['For linear regression, only ''Pearson'' is '...
+                'currently allowed']);
+    end
     npairs_dataset=numel(samples_pdist);
 
     [dsm_mat,msk]=get_dsm_mat_from_vector_or_cell(params.glm_dsm,...

diff --git a/tests/test_target_dsm_corr_measure.m b/tests/test_target_dsm_corr_measure.m
@@ -416,6 +416,8 @@
     aet(ds,'target_dsm',mat1,'type','Kendall');
     aet(ds,'target_dsm',mat1,'type',2);
 
+    % Spearman not allowed when using regress_dsm
+    aet(ds,'glm_dsm',mat1,'type','Spearman');
 
 
 function test_target_dsm_corr_measure_warnings_zero()