OBS Crashes on Incorrect URL and on Janus Restart

[ruddell]

If you enter an incorrect wss:// URL, OBS crashes instead of showing an error message stating it can't connect. It also crashes during streaming if the Janus server crashes or restarts. I tried to find where to catch the errors but didn't have any luck.

Tested on a Mac with latest master 51c0aa3

Stacktrace on invalid URL:

info: janus_stream_defaults
info: janus_stream_create
warning: Output 'adv_stream': Tried to set a delay value on a non-encoded output
info: janus_stream_start
info: -connecting to [url:wss://test.com,room:1234,username:,password:]
[2018-07-09 14:23:48] [info] asio async_connect error: asio.system:61 (Connection refused)
[2018-07-09 14:23:48] [info] Error getting remote endpoint: asio.system:22 (Invalid argument)
[2018-07-09 14:23:48] [fail] WebSocket Connection Unknown - "" / 0 websocketpp.transport.asio:3 Underlying Transport Error
[2018-07-09 14:23:48] [error] handle_connect error: Underlying Transport Error
[2018-07-09 14:23:48] [info] asio async_shutdown error: asio.ssl:336462100 (uninitialized)
[1]    95100 illegal hardware instruction  ./obs

Stacktrace on Janus restart during stream:

[2018-07-15 01:46:02] [error] handle_read_frame error: websocketpp.transport:7 (End of File)
[1]    13868 illegal hardware instruction  ./obs

[agouaillard-cosmo]

same comment: please indicate the type of resolution.

…

On Mon, Dec 10, 2018 at 3:22 PM Ben ***@***.***> wrote: Closed #31 <#31> via 5e2ae36 <5e2ae36> . — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AagY7Z--3ZUnWXnTisICEoXA_DpvKzRGks5u3gu_gaJpZM4VQIBA> .

[Ben-cos]

Fixed on commit 5e2ae36