Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial attempt to build out org #1

Merged
merged 17 commits into from
Sep 25, 2023
Merged

initial attempt to build out org #1

merged 17 commits into from
Sep 25, 2023

Conversation

kourosh-forti-hands
Copy link
Member

No description provided.

@kourosh-forti-hands kourosh-forti-hands requested review from douglas-f and a user August 11, 2023 14:46
@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@kourosh-forti-hands
added more functionality
8dcc899 
- cloudtrail
- config
- guard duty
- security hub

can't test bc I don't have a fresh org
@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

@kourosh-forti-hands
Copy link
Member Author

look into delegated admins for services, config, guardduty, sechub

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

olegkharytonenko-cf
olegkharytonenko-cf reviewed Sep 25, 2023
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
security_hub.tf Outdated Show resolved Hide resolved
guard_duty.tf Outdated Show resolved Hide resolved
guard_duty.tf Outdated Show resolved Hide resolved
guard_duty.tf Outdated Show resolved Hide resolved
guard_duty.tf Outdated Show resolved Hide resolved
guard_duty.tf Show resolved Hide resolved
guard_duty.tf Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Markdown Valid

@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

1 similar comment
@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/cloudtrail.tf CKV_AWS_252 Ensure CloudTrail defines an SNS Topic aws_cloudtrail.org-trail FAILED
/cloudtrail.tf CKV2_AWS_10 Ensure CloudTrail trails are integrated with CloudWatch Logs aws_cloudtrail.org-trail FAILED

Please review the above report. ⚠️

@kourosh-forti-hands
Copy link
Member Author

@olegkharytonenko-cf can you review this too?

@kourosh-forti-hands kourosh-forti-hands merged commit 4bde83d into main Sep 25, 2023
@kourosh-forti-hands kourosh-forti-hands deleted the initial-build branch September 25, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegkharytonenko-cf olegkharytonenko-cf olegkharytonenko-cf approved these changes

@douglas-f douglas-f Awaiting requested review from douglas-f

@mscribellito mscribellito Awaiting requested review from mscribellito

@BClev BClev Awaiting requested review from BClev

@ksnavely-cf ksnavely-cf Awaiting requested review from ksnavely-cf

@jtoureau-cf jtoureau-cf Awaiting requested review from jtoureau-cf

@cstano cstano Awaiting requested review from cstano

@nfrench-cf nfrench-cf Awaiting requested review from nfrench-cf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kourosh-forti-hands @olegkharytonenko-cf