Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KMS description & alias. #8

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Fix KMS description & alias. #8

merged 4 commits into from
Sep 28, 2023

Conversation

herman-wong-cf
Copy link
Contributor

No description provided.

@herman-wong-cf herman-wong-cf mentioned this pull request Sep 28, 2023
Closed
@github-actions
Copy link
Contributor

Checkov Scan Results 📖:

File Check ID Description Resource Checkov Result
/kms.tf CKV_AWS_356 Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions aws_iam_policy_document.nfw_kms_policy FAILED

Please review the above report. ⚠️

@github-actions
Copy link
Contributor

🌟 No Terraform files were modified in this PR or all modified Terraform files passed the Checkov checks. Good job! 🌟

@github-actions
Copy link
Contributor

Markdown Valid

@douglas-f douglas-f merged commit 62e90d0 into main Sep 28, 2023
3 checks passed
@douglas-f douglas-f deleted the fix_kms_example branch September 28, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglas-f douglas-f douglas-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@herman-wong-cf @douglas-f