Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard "Auto Newline" user setting and always assume auto newline in FileReader #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ishmaeel
Copy link

This may not be the proper place to fix this but it works nicely at least as a temporary measure. The alternative is a potential DoS when trying to open large files as discussed in #352.

Now FileReader always splits on newlines regardless of what the user selected for "Auto Newline" option from the menu. Fixes #352.

…in FileReader

This may not be the proper place to fix this but it works nicely at least as a temporary measure. The alternative is a potential DoS when trying to open large files as discussed in CobaltFusion#352.

Now FileReader always splits on newlines regardless of what the user selected for "Auto Newline" option from the menu. Fixes CobaltFusion#352.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved log files cannot be opened when "Auto Newline" is disabled.
1 participant