Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New grid scripts and fix cobaya-grid-create #326

Merged
merged 68 commits into from
Nov 21, 2023
Merged

New grid scripts and fix cobaya-grid-create #326

merged 68 commits into from
Nov 21, 2023

Conversation

cmbant
Copy link
Collaborator

@cmbant cmbant commented Oct 16, 2023

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 237 lines in your changes are missing coverage. Please review.

Comparison is base (7a47185) 84.82% compared to head (7b2419a) 81.72%.

Files Patch % Lines
cobaya/grid_tools/gridtables.py 60.36% 130 Missing ⚠️
cobaya/grid_tools/gridmanage.py 86.75% 42 Missing ⚠️
cobaya/grid_tools/batchjob.py 75.00% 34 Missing ⚠️
cobaya/grid_tools/gridconfig.py 88.33% 14 Missing ⚠️
cobaya/post.py 83.33% 5 Missing ⚠️
cobaya/grid_tools/gridrun.py 86.20% 4 Missing ⚠️
cobaya/grid_tools/batchjob_args.py 60.00% 2 Missing ⚠️
cobaya/theories/cosmo/boltzmannbase.py 33.33% 2 Missing ⚠️
cobaya/grid_tools/jobqueue.py 0.00% 1 Missing ⚠️
cobaya/likelihoods/base_classes/planck_clik.py 50.00% 1 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
- Coverage   84.82%   81.72%   -3.11%     
==========================================
  Files         124      133       +9     
  Lines        9169    11033    +1864     
==========================================
+ Hits         7778     9017    +1239     
- Misses       1391     2016     +625     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmbant
Copy link
Collaborator Author

cmbant commented Oct 16, 2023

@JesusTorrado test_cosmo_grid_2.yaml gives "'Varying Neff and total mass of 3 degenerate nu's'with theory code 'classy'.
This does not mean that you cannot use this model with that theory code; just that we have not implemented this yet." - can we just delete this file?

@cmbant cmbant changed the title changes to make cobaya-grid-create run without error New grid scripts and fix cobaya-grid-create Oct 23, 2023
@cmbant cmbant mentioned this pull request Nov 10, 2023
@cmbant
Copy link
Collaborator Author

cmbant commented Nov 20, 2023

@JesusTorrado OK to merge this? Most of the changes are orthogonal to the main code (and the grid code currently in master doesn't work)

@cmbant cmbant merged commit c376230 into master Nov 21, 2023
1 check passed
@cmbant cmbant mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants