Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Merge LobsterDog's image comparison test into master #1

Merged
merged 4 commits into from
May 20, 2019
Merged

Merge LobsterDog's image comparison test into master #1

merged 4 commits into from
May 20, 2019

Conversation

Cobular
Copy link
Owner

@Cobular Cobular commented May 16, 2019

No description provided.

@Cobular
Copy link
Owner Author

Cobular commented May 16, 2019

@ALobsterDog I'd really like to add this to the project! If you could work on it some more that would be great!

@JosephFKnight
Copy link
Collaborator

I'd be happy to. There's only one real change in this commit: the image assertion. all the other changes are from my autolinter, so you can take them or leave them.

I was trying to think of more assertions to add, did you have any broad-strokes goals or specific features in mind for the project?

add me on discord if you like. I'm Dinkus#8126.

@JosephFKnight
Copy link
Collaborator

right now I'm working on testing joining a voice channel, but i'll be away for the weekend so won't be able to work on it until next week.

@Cobular
Copy link
Owner Author

Cobular commented May 16, 2019

Autolinter

I'll run Black on it before I merge it. Would you mind using that for this project? It is similar to what you are using, might be it.

Adding image assertion

Make sure you add a demo of each assertion to example_tester.py if you can, I'll add the rest of the current ones in master soon. Looks neat!

More assertions

Whatever you think would be useful. I'll make a github project soon to track features, tracking them with a check box in the readme isn't going to work much longer. If you have ideas right now, just add them to the Checklist in the readme on your fork until I get the project going

Voice

Sounds useful, plz do!

Broad goals

I would like to add some setup teardown eventually, but that would probably be really difficult. I haven't given it much thought yet.

Discord

Sure, I might make a server for this sometime this weekend. I'll add you rn.

Thanks!

@JosephFKnight
Copy link
Collaborator

Hey Jake,

Just got back from vacation and excited to contribute. I see you've added a CLI, which is just fantastic, I'll have to test that out soon as I can.

For now I'm going to add an example test for the image assertion and get that committed asap. will likely get to it this afternoon.

voice will be trickier, but it's next on my docket.

@JosephFKnight
Copy link
Collaborator

@JakeCover image assertion pending your approval :)

@Cobular Cobular marked this pull request as ready for review May 20, 2019 20:01
@Cobular
Copy link
Owner Author

Cobular commented May 20, 2019

Thanks a ton! I will add a check to attachment.height is None rather than attachment is None (checks that attachment is image, not PDF or Video), but other than that it's great. Merging now.

@Cobular Cobular merged commit 183ec6c into Cobular:feature/ImageTest May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants