Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updater: reinstall option throws error #3293

Closed
tooomm opened this issue Jun 18, 2018 · 2 comments · Fixed by #3297
Closed

updater: reinstall option throws error #3293

tooomm opened this issue Jun 18, 2018 · 2 comments · Fixed by #3297
Labels
App - Cockatrice Tickets relating to the cockatrice application Defect - Regression UI / UX

Comments

@tooomm
Copy link
Member

tooomm commented Jun 18, 2018

System Information:
Client Version: 2.6.0 (2018-06-17)
Client Operating System: Windows 10 (10.0)
Build Architecture: 64-bit
Qt Version: 5.9.5
System Locale: de_DE

reinstall update
It doesn't matter if I select Stable or Beta channel in settings.

With 2.5.1 it works fine!
@tooomm tooomm added App - Cockatrice Tickets relating to the cockatrice application UI / UX Defect - Regression labels Jun 18, 2018
@ctrlaltca
Copy link
Contributor

The bug seems introduced by #2468, to be more precise by this line: https://github.com/Cockatrice/Cockatrice/pull/2468/files#diff-68c33782ee685fda6ebc3cc66405a16aR111
If you are already running the last version, updateUrl is not populated, so pressing the "reinstall" button starts the download of an empty url.
I'm not sure how it could work with 2.5.1.

ctrlaltca added a commit to ctrlaltca/Cockatrice that referenced this issue Jun 19, 2018
@ctrlaltca
fix Cockatrice#3293
c25b73f
@ctrlaltca ctrlaltca mentioned this issue Jun 19, 2018
Merged
@tooomm
Copy link
Member Author

tooomm commented Jun 19, 2018

I'm not sure how it could work with 2.5.1.

I tried it when 2.6.0 was out already, that's why probably. ;)

tooomm pushed a commit that referenced this issue Jun 19, 2018
@ctrlaltca @tooomm
Fix "reinstall" button in updater, fix #3293 (#3297)
0b3e86e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App - Cockatrice Tickets relating to the cockatrice application Defect - Regression UI / UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "reinstall" button in updater; Fix #3293 ctrlaltca/Cockatrice
2 participants
@ctrlaltca @tooomm