fix broken collaborators link #1987

tooomm · 2016-05-22T10:32:23Z

Since we have around 80 people that helped with translations already, I exchanged the outdated and not used "translator hall of fame" wiki page for a always up-to-date "collaborators" list on transifex.
Matches more what we have for developers as well.

Little downside: you need to be logged in to see the list, but that's fine I guess

exchanged the always outdated and not used "translator hall of fame" wiki page for a up-to-date "collaborators" list on transifex

mention-bot · 2016-05-22T10:32:25Z

By analyzing the blame information on this pull request, we identified @ZeldaZach, @ctrlaltca and @mattkelly to be potential reviewers

Daenyth · 2016-06-08T15:36:45Z

cockatrice/src/window_main.cpp

@@ -60,7 +60,7 @@
 #define GITHUB_PAGES_URL "https://cockatrice.github.io"
 #define GITHUB_CONTRIBUTORS_URL "https://github.com/Cockatrice/Cockatrice/graphs/contributors?type=c"
 #define GITHUB_CONTRIBUTE_URL "https://github.com/Cockatrice/Cockatrice#cockatrice"
-#define GITHUB_TRANSLATOR_RECOGNIZE_URL "https://github.com/Cockatrice/Cockatrice/wiki/Translators"
+#define TRANSIFEX_COLLABORATORS_URL "https://www.transifex.com/cockatrice/collaborators/?"


This brings me to a "manage contributors" screen if I'm logged in, or brings me to a login page if I'm logged out.

Does it show just a list if you're not a project admin?

I'll check and come back to you after the weekend.

ZeldaZach · 2016-06-14T15:44:47Z

This is forcing me to login, so this isn't too good for what we want...

tooomm · 2016-06-14T18:01:08Z

What do we want?
I doubt it's what we have right now for several obvious reasons.
This is the only other possibility I can come up with which offers a complete solution that is always up to date and doesn't need maintenance...

I think we are even better off just removing the link than having that "nonsense" wiki page.

The wiki page only features two new translators since Dae took over btw, all others are from the early days of the app. Not to mention how much strings changed in between.
It's just heavily outdated and nobody is going to update it nor willing to maintain that page.

Both of the new translators mentioned there happened to contribute code here too. Coincidence? ;) What about the 80 other guys who might contributed way more translations wise?

Daenyth · 2016-07-01T12:20:54Z

I emailed transifex asking about a public credit page. If they have a link we can use then I'll post it here, otherwise we should update the wiki page to be more generic and not need maintenance.

tooomm · 2016-07-01T15:26:34Z

Cool. Let us know what they reply!

Daenyth · 2016-07-02T23:56:37Z

Hi Gavin,

Thank you for contacting Transifex support and submitting your request.

Regarding your case, first of all, I would like to clarify that pages that are related to the teams and the collaborators of your organization are not publicly accessible.

So, the only way is to somehow export the information and share it. A suggestion I could make is to use the API call that is mentioned in our documentation guide here. So, in your case, the URL will be the following one:

https://www.transifex.com/api/2/project/cockatrice/languages/
(not publicly accessible as well)

So, you will get a list of all the contributors as follows:
{
        "coordinators": [
            "Daenyth"
        ], 
        "language_code": "zh-Hans", 
        "translators": [
            "Pascal_Yu", 
            "359763432"
        ], 
        "reviewers": []
    }, 
    {
        "coordinators": [
            "Daenyth"
        ], 
        "language_code": "cs", 
        "translators": [
            "Tomeno", 
            "iameld3st", 
            "LethalPigeon7", 
            "irendie"
        ], 
The information you are looking for can also be found on the Manage Collaborators page. You can use the available filters but unfortunately, there is not any option to filter the results based on a specific project.

Another solution would be to visit each target group page and find the translators that belong to it. But I think that this is a more time-consuming workaround.

I hope that the above helps.

Please feel free to reach out to me in case you need any further clarifications.

tooomm · 2016-07-09T08:57:35Z

Ok, I updated the wording accordingly and reverted the link change.

So we go with that API call and some kind of script-generated wiki page?

Daenyth · 2016-07-09T15:50:00Z

I think that's the best way to handle it eventually.

Daenyth · 2016-07-09T15:51:17Z

cockatrice/src/window_main.cpp

@@ -60,7 +60,7 @@
 #define GITHUB_PAGES_URL "https://cockatrice.github.io"
 #define GITHUB_CONTRIBUTORS_URL "https://github.com/Cockatrice/Cockatrice/graphs/contributors?type=c"
 #define GITHUB_CONTRIBUTE_URL "https://github.com/Cockatrice/Cockatrice#cockatrice"
-#define GITHUB_TRANSLATOR_RECOGNIZE_URL "https://github.com/Cockatrice/Cockatrice/wiki/Translators"
+#define GITHUB_TRANSIFEX_TRANSLATORS_URL "https://github.com/Cockatrice/Cockatrice/wiki/Translator-Hall-of-Fame"


👎 changing the link url breaks the old versions already out there. If we do change the url we need to keep the old one but have it redirect to the new one.

That's the original working link. We just have the Translators Hall of Fame to name them. It has always been like that. Zach created it like one year ago.

I'm not sure if I like that page name though...

Maybe if was broken all the time? Can't tell for sure.

The link in the old version of the code is broken. I guess no one ever
clicked it, or if they did, they didn't report anything.

On Sat, Jul 9, 2016 at 11:58 AM tooomm notifications@github.com wrote:

In cockatrice/src/window_main.cpp
#1987 (comment):

@@ -60,7 +60,7 @@
#define GITHUB_PAGES_URL "https://cockatrice.github.io"
#define GITHUB_CONTRIBUTORS_URL "https://github.com/Cockatrice/Cockatrice/graphs/contributors?type=c"
#define GITHUB_CONTRIBUTE_URL "https://github.com/Cockatrice/Cockatrice#cockatrice"
-#define GITHUB_TRANSLATOR_RECOGNIZE_URL "https://github.com/Cockatrice/Cockatrice/wiki/Translators

"

+#define GITHUB_TRANSIFEX_TRANSLATORS_URL "https://github.com/Cockatrice/Cockatrice/wiki/Translator-Hall-of-Fame"

That's the original working link. We just have the Translators Hall of
Fame
https://github.com/Cockatrice/Cockatrice/wiki/Translator-Hall-of-Fame
to name them. It has always been like that. Zach created it like one year
ago.

I'm not sure if I like that page name though...

Maybe if was broken all the time? Or Can't tell for sure.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/Cockatrice/Cockatrice/pull/1987/files/6d9bc2347ae0920adc664fedf210f6d56b02aa8a#r70168748,
or mute the thread
https://github.com/notifications/unsubscribe/AAA5NHQvR8iUfq35Hxk99tgoM3LDizc0ks5qT8UxgaJpZM4Ij9db
.

ZeldaZach · 2016-10-31T19:35:12Z

@tooomm Have you thought of another way to deal with this?

tooomm · 2016-11-01T10:07:29Z

We could merge to finally get the link to the wiki working... (it used to be a dead link all the time)

Then ticket the api call and script based wiki page refresh/generation. It could be combined with a tx fetch/push translations script maybe.

Daenyth · 2017-03-14T22:00:03Z

What's the status of this? Is this helpful still? If so we should get it cleaned up for merge. If not we should close it. If there's work to do before or after merging this, let's ticket it so we don't lose track

ZeldaZach · 2017-03-14T22:03:11Z

Since users would have to login to see translation status and such for the "hall of fame" i'm fine with our current wiki on the subject.

Daenyth · 2017-03-14T22:07:06Z

So we should close?

tooomm · 2017-03-18T21:52:39Z

@ZeldaZach Did you even check what this is doing before closing? ;)

What's the status of this? Is this helpful still?

Yes! In the current state this fixes a broken link which has been in the client for like 2 years...
It also renames the link and the variable.

Since users would have to login to see translation status and such for the "hall of fame" i'm fine with our current wiki on the subject.

This is not the case. I highly dislike our current wiki and still think it's pretty useless.
So I repeat my suggestion from the last post #1987 (comment):

We could merge to finally get the link to the wiki working... (it used to be a dead link all the time)

Then ticket the api call and script based wiki page refresh/generation. It could be combined with a tx fetch/push translations script maybe.

ZeldaZach

Looks good to me

exchanged collaborators link

519ed15

exchanged the always outdated and not used "translator hall of fame" wiki page for a up-to-date "collaborators" list on transifex

Daenyth reviewed Jun 8, 2016
View reviewed changes

wording update + undo link change

926fc9a

now with correct link

6d9bc23

Daenyth reviewed Jul 9, 2016
View reviewed changes

tooomm changed the title ~~exchanged collaborators link~~ [WIP] exchanged collaborators link Jul 24, 2016

ZeldaZach closed this Mar 15, 2017

tooomm reopened this Mar 18, 2017

tooomm changed the title ~~[WIP] exchanged collaborators link~~ fix broken collaborators link Mar 18, 2017

tooomm requested review from Daenyth and ZeldaZach March 22, 2017 20:15

ZeldaZach approved these changes Mar 22, 2017

View reviewed changes

ZeldaZach merged commit 2c3b85a into Cockatrice:master Mar 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix broken collaborators link #1987

fix broken collaborators link #1987

tooomm commented May 22, 2016

mention-bot commented May 22, 2016

Daenyth Jun 8, 2016

tooomm Jun 9, 2016

ZeldaZach commented Jun 14, 2016

tooomm commented Jun 14, 2016

Daenyth commented Jul 1, 2016

tooomm commented Jul 1, 2016

Daenyth commented Jul 2, 2016

tooomm commented Jul 9, 2016

Daenyth commented Jul 9, 2016

Daenyth Jul 9, 2016

tooomm Jul 9, 2016 •

edited

Loading

Daenyth Jul 10, 2016

ZeldaZach commented Oct 31, 2016

tooomm commented Nov 1, 2016 •

edited

Loading

Daenyth commented Mar 14, 2017

ZeldaZach commented Mar 14, 2017

Daenyth commented Mar 14, 2017 •

edited

Loading

tooomm commented Mar 18, 2017

ZeldaZach left a comment

fix broken collaborators link #1987

fix broken collaborators link #1987

Conversation

tooomm commented May 22, 2016

mention-bot commented May 22, 2016

Daenyth Jun 8, 2016

Choose a reason for hiding this comment

tooomm Jun 9, 2016

Choose a reason for hiding this comment

ZeldaZach commented Jun 14, 2016

tooomm commented Jun 14, 2016

Daenyth commented Jul 1, 2016

tooomm commented Jul 1, 2016

Daenyth commented Jul 2, 2016

tooomm commented Jul 9, 2016

Daenyth commented Jul 9, 2016

Daenyth Jul 9, 2016

Choose a reason for hiding this comment

tooomm Jul 9, 2016 • edited Loading

Choose a reason for hiding this comment

Daenyth Jul 10, 2016

Choose a reason for hiding this comment

ZeldaZach commented Oct 31, 2016

tooomm commented Nov 1, 2016 • edited Loading

Daenyth commented Mar 14, 2017

ZeldaZach commented Mar 14, 2017

Daenyth commented Mar 14, 2017 • edited Loading

tooomm commented Mar 18, 2017

ZeldaZach left a comment

Choose a reason for hiding this comment

tooomm Jul 9, 2016 •

edited

Loading

tooomm commented Nov 1, 2016 •

edited

Loading

Daenyth commented Mar 14, 2017 •

edited

Loading