Add missing feature rememberance to client #2275
Conversation
Fix Cockatrice#2249 Add the ability for the client to remember the missing features that it received from the server it last connected to and not display the "missing/optional feature" message at every login.
woogerboy21
added
the
App - Cockatrice
|
Awesome! I'll review as soon as I get a chance On Fri, Nov 11, 2016, 12:28 AM woogerboy21 notifications@github.com wrote:
|
|
So the user isn't allowed to find out what the missing feature is again from some esoteric window deep inside a help menu? :D |
Im confused by this. The user is never presented the missing features that there client has unless its a required feature on the server preventing them from logging in. Otherwise there is a popup on login that indicates they are missing features that the server they are connecting to understands. And before this change it pops up every single time the user logs in and there client is missing the feature. With this change the only difference in user experience is that the client will only present the popup message about missing features once as the client now remembers what those features are. If say for example they log in with a down level client that is missing feature a, there client remembers feature a. Then if the server upgrades again and now the client is missing feature a & b, the user will be presented again with the message when that condition happens (and so on) but wont be presented with the popup every single login. The experience for what features the users see's if denied access to the server from a missing feature doesnt change. Or are you wanting the ability to see what those missing features might be? If so I wouldnt suggest it be in some buried popup window but possibly in the debug log. Maybe on startup? |
|
Was this ever looked at by anyone? I know personally with work and the holiday stuff pretty much here I havent had a bunch of time myself to do much more project wise. |
| @@ -135,6 +136,13 @@ void RemoteClient::processConnectionClosedEvent(const Event_ConnectionClosed & / | |||
| void RemoteClient::loginResponse(const Response &response) | |||
| { | |||
| const Response_Login &resp = response.GetExtension(Response_Login::ext); | |||
|
|
|||
| QString possibleMissingFeatures; | |||
There was a problem hiding this comment.
Why not a QSet<QString>? That would provide much easier checking, I'd think
There was a problem hiding this comment.
I actually started out by using a QSet<QString> but ran into an issue with doing so. At this point though I don't recall what the issue was and it very well could have been something to do with me taking a different approach and then changing it after the failures occurred.
Fix #2249
Add the ability for the client to remember the missing features that it received from the server it last connected to and not display the "missing/optional feature" message at every login. At each startup the client checks the known missing feature list and compares it to its feature set clearing any known features that have been added after a client upgrade. The client will now only display the missing / optional feature window when a new missing feature is found upon connecting to a server only once. Afterwords it will not display the message until an even newer feature the client is missing is found.