Added registration email blacklist #2352
Conversation
Added the ability to define email blacklist for user registration. Now server operators can prevent users from registering accounts that contain providers they do not wish users to use.
| ; You can prevent users from using certain mail domains for registration. This setting contains a | ||
| ; comma-seperated list of email provider domains that you would like to prevent users from using | ||
| ; during registration. Example: "10minutemail.com,gmail.com,mail.com" | ||
| emailblacklist="" |
There was a problem hiding this comment.
Maybe change the name of the config value to emailproviderblacklist so it's a little more clear
Updated servatrice ini option name for clarity.
|
@ZeldaZach Updated... |
|
Sure, give me a bit and Ill see if I can stand something up this afternoon people can bounce tests off of. |
|
Code looks fine, the only note is about the use of "contains" when checking the provided email address against the blacklist: eg. if i blacklist "mail.com", it will implicitly block also "gmail.com", "whatevermail.com", "mail.computers.biz", etc.. I don't see this as a real problem as long as it's stated clearly in the comment before the setting, but the current comment mentions "10minutemail.com,gmail.com,mail.com" that is a misleading example as it contains "mail.com". |
|
@ctrlaltca Nice spotting on that. I don't like the wildcard effect of the blanket blocks (mail.com blocks gmail.com, etc). Can this PR be redone so it blocks only that specific host @woogerboy21 ? |
|
@ZeldaZach I would prefer to keep the wildcard affect myself. Updating the description would be more of a solution that what your suggesting. |
Added implicit explination
|
Haven't we something like that working here? #2200 |
|
@tooomm That is for the actual username, we could apply it to the email component of registration as well. Regex always seems like overkill to me though. I've used it in other project (primarily for string text finding card pricing from websites) and though it allows for very granular definition of search criteria, it also adds a pretty large complexity component to those that don't really understand how to use it. |
|
@ZeldaZach I have a new testing server up with this rolled in. You can get to it by going to: host: testing.woogerworks.com The websocket server is disabled and the regular client is running on the port listed above. |
woogerboy21
added
the
App - Servatrice
|
@ZeldaZach Just an FYI on this one. I have email capabilities setup as well as changed the testing server information on the last post. So when you get around to testing this make sure you have things correct. |
Fix #1862
Added the ability to define email blacklist for user registration. Now server operators can prevent users from registering accounts that contain providers they do not wish users to use. This also adds a new response protocol item with new client popup response indicating the reason for denied registration.