fix incorrect pawn icons #2436
Merged
fix incorrect pawn icons #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tritoch does this fix the pawns for you? |
Daenyth
approved these changes
Mar 2, 2017
cockatrice/src/tab_message.cpp
Outdated
| @@ -115,7 +115,8 @@ void TabMessage::actLeave() | |||
| void TabMessage::processUserMessageEvent(const Event_UserMessage &event) | |||
| { | |||
| const UserLevelFlags userLevel(event.sender_name() == otherUserInfo->name() ? otherUserInfo->user_level() : ownUserInfo->user_level()); | |||
| chatView->appendMessage(QString::fromStdString(event.message()), 0,QString::fromStdString(event.sender_name()), userLevel, QString::fromStdString(otherUserInfo->privlevel()), true); | |||
| const QString userPriv(event.sender_name() == otherUserInfo->name() ? QString::fromStdString(otherUserInfo->privlevel()) : QString::fromStdString(ownUserInfo->privlevel())); | |||
There was a problem hiding this comment.
Minor tweak for duplication;
auto userInfo = event.sender_name() == otherUserInfo->name() ? otherUserInfo : ownUserInfo;
const UserLevelFlags userLevel(userInfo->user_level());
const QString userPriv = QString::fromStdString(userInfo->privlevel());
|
Pawns are now correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2386
The issue came about because we always showed the pawn of "other user's pawn rank" instead of doing a tertiary case (like we do for flags).
This fixes the issue.