Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2608; fix #2609; fix #2611 #2636

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

ctrlaltca
Copy link
Contributor

Related Ticket(s)

Short roundup of the initial problem

The initial PR #2605 was incomplete

What will change with this Pull Request?

The "join" button will be disabled if the room is full.
The "spectate" button will be disabled/enabled both when the game row gets selected using the mouse, keyboard or any other input method.

Copy link
Member

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "spectate" button will be disabled/enabled both when the game row gets selected using the mouse, keyboard or any other input method.

Works, same with the new disabled "Join" button 👍

Please double check on other platform before merging.

@ctrlaltca
Copy link
Contributor Author

@backendr may want to test this before merging.

@ctrlaltca ctrlaltca merged commit acb40bc into Cockatrice:master Apr 24, 2017
@ctrlaltca ctrlaltca deleted the fix_game_buttons branch April 24, 2017 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants