Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in replay #2649

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Fix crash in replay #2649

merged 1 commit into from
Apr 25, 2017

Conversation

ctrlaltca
Copy link
Contributor

Short roundup of the initial problem

While investigating #2332, cockatrice crashed because of a null ptr deref.

What will change with this Pull Request?

Cockatrice won't crash anymore when playing replays.

ZeldaZach
ZeldaZach approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

Daenyth
Daenyth approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@Daenyth Daenyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait until our compilers support std::optional :|

@ctrlaltca ctrlaltca merged commit a46c715 into Cockatrice:master Apr 25, 2017
@ctrlaltca ctrlaltca deleted the fix_crash branch April 25, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daenyth Daenyth Daenyth approved these changes

@ZeldaZach ZeldaZach ZeldaZach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctrlaltca @Daenyth @ZeldaZach