Allow placement below top X cards #2666
Conversation
cockatrice/src/player.cpp
Outdated
| @@ -723,6 +725,7 @@ void Player::retranslateUi() | |||
| } | |||
|
|
|||
| aMoveToTopLibrary->setText(tr("&Top of library")); | |||
| aMoveToXfromTopOfLibrary->setText(tr("Below X cards...")); | |||
| cmd->mutable_cards_to_move()->CopyFrom(idList); | ||
| cmd->set_target_player_id(getId()); | ||
| cmd->set_target_zone("deck"); | ||
| cmd->set_x(number); |
There was a problem hiding this comment.
What happens if I set number = 100 in the UI but I only have 60 cards in the deck?
There was a problem hiding this comment.
if number > deck.size() { number = deck.size() }
|
Thanks guys! This is awesome. |
| void Player::actMoveCardXCardsFromTop() | ||
| { | ||
| bool ok; | ||
| int number = QInputDialog::getInt(0, tr("Place card X cards from top library"), tr("How many cards from the top of the deck should this card be placed:"), defaultNumberTopCardsToPlaceBelow, 1, 2000000000, 1, &ok); |
There was a problem hiding this comment.
Is this X cards ABOVE our card or X-1? Unexpectedly Absent says "just beneath the top X cards of your library" whereas Oust says second from the top which is clarified as 6/15/2010: If the targeted creature’s owner has one or more cards in his or her library, that creature is put into that library directly under the top card.
There was a problem hiding this comment.
2nd from top = means put 2 in input.
Beneath top X cards = X+1 is your input
| void Player::actMoveCardXCardsFromTop() | ||
| { | ||
| bool ok; | ||
| int number = QInputDialog::getInt(0, tr("Place card X cards from top library"), tr("How many cards from the top of the deck should this card be placed:"), defaultNumberTopCardsToPlaceBelow, 1, 2000000000, 1, &ok); |
There was a problem hiding this comment.
Should be top of library not top library
Related Ticket(s)
NOTE: This PR also addresses an option in the server that if we sent it (-inf, -2] as X, it would crash the user. This just prevents a crash and is backwards compatible with prior client/servers.
Short roundup of the initial problem
Couldn't place a card X cards from top easily into the deck.
Screenshots